Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14713 - Updating help text security panel #2658

Merged
merged 1 commit into from
Apr 15, 2019
Merged

MM-14713 - Updating help text security panel #2658

merged 1 commit into from
Apr 15, 2019

Conversation

asaadmahmood
Copy link
Contributor

Summary

MM-14713 - Updating help text security panel

Ticket Link

https://mattermost.atlassian.net/browse/MM-14713

@asaadmahmood asaadmahmood added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 15, 2019
@asaadmahmood asaadmahmood added this to the v5.10.0 milestone Apr 15, 2019
@hmhealey hmhealey merged commit cf1eca3 into mattermost:master Apr 15, 2019
hmhealey pushed a commit that referenced this pull request Apr 15, 2019
@asaadmahmood @hmhealey
MM-14713 - Updating help text security panel (#2658)
df8f3c5
@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 15, 2019
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 4: Reviews Complete All reviewers have approved the pull request labels Apr 16, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 17, 2019
@asaadmahmood asaadmahmood deleted the MM-14713 branch April 18, 2019 15:08
@DHaussermann DHaussermann added CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone labels Apr 24, 2019
@DHaussermann
Copy link

For some reason this did not get resolved in 5.10.
This issue is still present on 5.11-release.

@hanzei or @saturninoabril would either of you be able to cherry-pick this to 5.11-release to see if it solves the problem?

(re-added label for 5.11 branch)

@hanzei
Copy link
Contributor

hanzei commented Apr 24, 2019

As you can see in df8f3c5 this change is already part of the release-5.11 branch.

@saturninoabril
Copy link
Member

I agree. It's both on 5.10 and 5.11.

@DHaussermann
Copy link

Thanks. strange that the cherry-pick did not resolve the issue. I will follow up with Asaad.

@hanzei hanzei added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 26, 2019
TranMacTien pushed a commit to Designveloper/mattermost-webapp that referenced this pull request Jun 13, 2019
@asaadmahmood @TranMacTien
MM-14713 - Updating help text security panel (mattermost#2658)
804a1e1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saturninoabril saturninoabril saturninoabril approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.10.0
Development

Successfully merging this pull request may close these issues.
7 participants
@asaadmahmood @DHaussermann @hanzei @saturninoabril @hmhealey @lindy65 @amyblais